cmd: Add subtract-fee flag #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-cli canceled.
|
matevz
force-pushed
the
matevz/feature/subtract-fee
branch
2 times, most recently
from
cfe754d to
9bfa8f0
Compare
matevz
force-pushed
the
matevz/feature/subtract-fee
branch
2 times, most recently
from
91ad28a to
b166d1b
Compare
matevz
force-pushed
the
matevz/feature/subtract-fee
branch
5 times, most recently
from
e72f670 to
c0881a8
Compare
matevz
force-pushed
the
matevz/feature/subtract-fee
branch
2 times, most recently
from
b4f3e83 to
0ef0488
Compare
kostko
reviewed
Nov 12, 2024
Used by: - oasis account transfer --paratime xyz - oasis account trnasfer --no-paratime - oasis account withdraw
matevz
force-pushed
the
matevz/feature/subtract-fee
branch
from
0ef0488 to
2c49a09
Compare
kostko
approved these changes
Nov 12, 2024
|
Merged to fix examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples gas fee computation and signing the transactions. If
--subtract-feeis provided, then the fee is subtracted from the transaction before signing it.Note: Gas estimation for consensus transactions is higher for 8, because the nonce and the fee objects are now populated in the tx before estimating the gas.
Implements #247