feat(cmd/rofl): Add initial support for ROFL app management #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-cli canceled.
|
kostko
force-pushed
the
kostko/feature/rofl
branch
5 times, most recently
from
3971f57 to
c72d1ce
Compare
matevz
approved these changes
Jul 18, 2024
cmd/rofl.go
Outdated
| } | ||
|
|
||
| roflCreateCmd = &cobra.Command{ | ||
| Use: "create <policy.json>", |
There was a problem hiding this comment.
Please add an example policy to the docs.
kostko
force-pushed
the
kostko/feature/rofl
branch
4 times, most recently
from
c1b9808 to
fc183c8
Compare
|
How can a user know what's the staking threshold to register a ROFL app? This should probably go somewhere here right? |
|
Not there as that one is for network-wide stuff? The ROFL subcommand could mention it somewhere, e.g. when trying to create a new ROFL app and not having enough funds? |
kostko
force-pushed
the
kostko/feature/rofl
branch
from
fc183c8 to
68591e4
Compare
kostko
force-pushed
the
kostko/feature/rofl
branch
from
68591e4 to
53eddfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.