Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): Support non-interactive network add-local and paratime add #279

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat(cmd): Support non-interactive network add-local and paratime add #279

merged 1 commit into from
Sep 10, 2024

Conversation

amela
Copy link
Member

@amela amela commented Sep 5, 2024

No description provided.

@amela amela requested a review from matevz September 5, 2024 12:20
@amela amela linked an issue Sep 5, 2024 that may be closed by this pull request
Support non-interactive network add-local and paratime add #275
Closed
@netlify Netlify
Copy link

netlify bot commented Sep 5, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-cli ready!

Name Link
🔨 Latest commit 271db45
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/66dfe5917249b200084f50c4
😎 Deploy Preview https://deploy-preview-279--oasisprotocol-cli.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amela amela force-pushed the amela/add-flags-network-add-local-paratime-add branch from 0ed6310 to 28b9230 Compare September 5, 2024 12:27
matevz
matevz reviewed Sep 5, 2024
View reviewed changes
cmd/network/add_local.go Outdated Show resolved Hide resolved
@amela amela force-pushed the amela/add-flags-network-add-local-paratime-add branch 4 times, most recently from f874577 to 419b7aa Compare September 6, 2024 03:52
@amela amela marked this pull request as ready for review September 6, 2024 03:55
@amela amela requested a review from matevz September 6, 2024 03:55
matevz
matevz reviewed Sep 6, 2024
View reviewed changes
docs/network.md Outdated Show resolved Hide resolved
docs/network.md Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
docs/paratime.md Outdated Show resolved Hide resolved
matevz
matevz reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ParaTime suggestions/fixes.

cmd/paratime/add.go Outdated Show resolved Hide resolved
cmd/paratime/add.go Outdated Show resolved Hide resolved
cmd/paratime/add.go Outdated Show resolved Hide resolved
cmd/paratime/add.go Show resolved Hide resolved
@amela amela force-pushed the amela/add-flags-network-add-local-paratime-add branch 2 times, most recently from de47ad7 to c865d2b Compare September 9, 2024 06:54
@amela amela requested a review from matevz September 9, 2024 07:01
matevz
matevz approved these changes Sep 9, 2024
View reviewed changes
docs/paratime.md Outdated Show resolved Hide resolved
@amela amela force-pushed the amela/add-flags-network-add-local-paratime-add branch from c865d2b to 271db45 Compare September 10, 2024 06:22
@amela amela changed the title feat(cmd/network): Support non-interactive add-local and paratime add feat(cmd): Support non-interactive network add-local and paratime add Sep 10, 2024
@amela amela merged commit 246a950 into master Sep 10, 2024
4 checks passed
@amela amela deleted the amela/add-flags-network-add-local-paratime-add branch September 10, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matevz matevz matevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support non-interactive network add-local and paratime add
2 participants
@amela @matevz