Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Windows build support 2 #344

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

ZigaMr
Copy link
Contributor

@ZigaMr ZigaMr commented Jan 10, 2025

This PR adds oasis.exe rule to Makefile.
Followup to #342

@ZigaMr ZigaMr requested a review from matevz January 10, 2025 18:24
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit f35c069
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/6784d6046cda9300080d1951

Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM.

Makefile Outdated
clean
windows
clean \
build-windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move up right next to build.

@ZigaMr ZigaMr force-pushed the ZigaMr/windows-build-support-2 branch from afd4b9c to 8af30e9 Compare January 13, 2025 08:48
Add oasis.exe rule

Remove .exe extension which is handled by goreleaser

Move build-windows phony target

Change release-build option to previous version
@ZigaMr ZigaMr force-pushed the ZigaMr/windows-build-support-2 branch from dd752c6 to f35c069 Compare January 13, 2025 08:59
@ZigaMr ZigaMr merged commit b67f071 into master Jan 13, 2025
4 checks passed
@ZigaMr ZigaMr deleted the ZigaMr/windows-build-support-2 branch January 13, 2025 09:05
@kostko kostko linked an issue Jan 14, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Windows builds
2 participants