cmd/network: Extract absolute path of local endpoint in add-local #350
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
abukosek
force-pushed
the
andrej/bugfix/add-local-abspath
branch
from
598c7aa to
5c33d25
Compare
cmd/network/add_local.go
Outdated
| cobra.CheckErr(fmt.Errorf("malformed path in RPC endpoint: %w", err)) | ||
| } | ||
| net.RPC = parsedRPC.String() | ||
|
|
There was a problem hiding this comment.
While you're at it, can you also check whether parsedRPC.Opaque() matches local file and print something like Warning: File ${parsedRPC.Opaque()} exists locally. Did you mean unix:${parsedRPC.Opaque()}?
There was a problem hiding this comment.
Hmm, but parsedRPC.Opaque comes from the original RPC endpoint, which has to start with unix: anyway or the validation will fail. I'm not sure what this check is supposed to accomplish.
There was a problem hiding this comment.
This bad UX existed before:
$ oasis net add test .oasis-node3/data_validator/internal.sock
Error: rpc error: code = Unavailable desc = name resolver error: produced zero addresses
There was a problem hiding this comment.
OK, but this is a totally different issue :) The original issue never mentioned adding this functionality to the add command, just to add-local.
There was a problem hiding this comment.
I've added the extra functionality, please retry :)
There was a problem hiding this comment.
Can you also add the same behavior to add-local:
$ ./oasis net add-local test internal.sock
Error: rpc-endpoint 'internal.sock' is not local
afb1700 to
7e2165a
Compare
abukosek
force-pushed
the
andrej/bugfix/add-local-abspath
branch
from
7e2165a to
9d951d5
Compare
Closes #273.