Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduces metadata size #75

Merged
merged 4 commits into from
Oct 4, 2024
Merged

reduces metadata size #75

merged 4 commits into from
Oct 4, 2024

Conversation

CedarMist
Copy link
Member

  • goes from 428233 gas to 337038 gas (~90k gas saving) for a simple poll. With xchain ACL gas saving will be more.
  • changes cbor library used to same one used by sapphire paratime client
  • uses uint8array instead of hex encoded strings in metadata
  • uses single character names
  • removed unnecessary info from metadata (such as ACL address) which can be retrieved from elsewhere
  • fixes PollManager tests

@CedarMist
reduces metadata size
fe29d7a 
 * goes from 428233 gas to 337038 gas (~90k gas saving) for a simple poll. With xchain ACL gas saving will be more.
 * changes cbor library used to same one used by sapphire paratime client
 * uses uint8array instead of hex encoded strings in metadata
 * uses single character names
 * removed unnecessary info from metadata (such as ACL address) which can be retrieved from elsewhere
 * fixes PollManager tests
@CedarMist CedarMist self-assigned this Oct 3, 2024
@CedarMist CedarMist marked this pull request as ready for review October 3, 2024 19:24
csillag
csillag approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@csillag csillag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, adjusted, LGTM.
Merging.

@csillag csillag merged commit 25596c5 into master Oct 4, 2024
1 check passed
@csillag csillag deleted the CedarMist/reduce-metadata-size branch October 4, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csillag csillag csillag approved these changes

Assignees

@CedarMist CedarMist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CedarMist @csillag