Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

short URLs & gasless withdraw on close #86

Merged
merged 14 commits into from
Oct 23, 2024
Merged

short URLs & gasless withdraw on close #86

merged 14 commits into from
Oct 23, 2024

Conversation

CedarMist
Copy link
Member

@CedarMist CedarMist commented Oct 10, 2024 •
edited
Loading

I switched the .env.development around, so .env.development is comitted which only includes the localhost URL, while the localnet deployment goes into .env.development.local and is .gitignore'd

  • Upgrade to Solidity 0.8.28
  • Use PNPM 9
  • add sapphire-localnet for tests
  • fix /demo url
  • delete gasless voting info on poll deletion
  • when poll is closed automatically broadcast the GasWithdrawTx events
  • gasless poll closing?

@CedarMist CedarMist self-assigned this Oct 10, 2024
@CedarMist CedarMist force-pushed the CedarMist/short-urls branch from bab9d67 to 1528f32 Compare October 10, 2024 13:49
@csillag csillag force-pushed the CedarMist/short-urls branch from dbd3a58 to e77d5d3 Compare October 11, 2024 18:10
@csillag csillag force-pushed the CedarMist/short-urls branch from e77d5d3 to 8f27c44 Compare October 11, 2024 20:28
@csillag csillag force-pushed the CedarMist/short-urls branch from 8f27c44 to ebd271f Compare October 11, 2024 21:59
@csillag
Centralize slug handling
f272997 
- Add utility function for generating poll path from poll ID,
  and another one from getting poll ID from url params,
  abstracting away all the meddling with slug.
- proposalIdToSlug: accept both the pure and the 0x hex form of id
@csillag csillag force-pushed the CedarMist/short-urls branch from ebd271f to f272997 Compare October 11, 2024 22:10
csillag
csillag approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@csillag csillag left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Adjusted. LGTM. Merging.

@CedarMist CedarMist added the enhancement New feature or request label Oct 12, 2024
@CedarMist CedarMist marked this pull request as ready for review October 13, 2024 15:26
@CedarMist CedarMist requested a review from csillag October 13, 2024 15:31
@CedarMist CedarMist marked this pull request as draft October 13, 2024 15:37
@CedarMist
Copy link
Member Author

So, with gasless voting refund works in the UI

image

But, figuring out why unit test failed, given it's the same underlying contract

@CedarMist CedarMist marked this pull request as ready for review October 14, 2024 10:24
@HarryR
Copy link

HarryR commented Oct 21, 2024

@csillag Are we good to merge this?

@csillag
Copy link
Collaborator

csillag commented Oct 21, 2024 •
edited
Loading

@csillag Are we good to merge this?

@HarryR Please See my messages on slack! I think I found some problems...

@CedarMist CedarMist merged commit b035655 into master Oct 23, 2024
1 check passed
@CedarMist CedarMist deleted the CedarMist/short-urls branch October 23, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csillag csillag Awaiting requested review from csillag

Assignees

@CedarMist CedarMist

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CedarMist @HarryR @csillag