Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooling: Specify yarn version via packageManager #1053

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

aefhm
Copy link
Contributor

@aefhm aefhm commented Dec 12, 2024

Description

Corepack likes an explicit packageManager. I believe this is 1.22.22 for us for now.

Note. We could consider going up to v4 as we are already on Node 20.

@aefhm aefhm self-assigned this Dec 12, 2024
@aefhm aefhm requested a review from matevz December 12, 2024 05:18
@aefhm aefhm added p:2 Low priority question Further information is requested and removed question Further information is requested labels Dec 12, 2024
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for oasisprotocol-docs ready!

Name Link
🔨 Latest commit b4fadd9
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-docs/deploys/6764fb8d2a17b20008908218
😎 Deploy Preview https://deploy-preview-1053--oasisprotocol-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matevz
Copy link
Member

matevz commented Dec 18, 2024

Is this really needed?
Node API docs tells me the packageManager directive is still experimental.

@aefhm
Copy link
Contributor Author

aefhm commented Dec 18, 2024

Node API docs

Not a must have. I think people using corepack will get that insertion in their diffs.

Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we leave out the sha512 hash? It clutters the package.json file and I don't see security issues omitting it.

@aefhm aefhm force-pushed the xz/specify-yarn-in-package branch from ea364ee to c958216 Compare December 20, 2024 05:07
@aefhm aefhm force-pushed the xz/specify-yarn-in-package branch from c958216 to b4fadd9 Compare December 20, 2024 05:07
@aefhm aefhm enabled auto-merge December 20, 2024 05:07
@aefhm aefhm merged commit 0de25b6 into main Dec 20, 2024
2 checks passed
@aefhm aefhm deleted the xz/specify-yarn-in-package branch December 20, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:2 Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants