-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
23.0: docs/state-sync: Update state sync docs #620
Conversation
✅ Deploy Preview for trusting-archimedes-14c863 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, make sure to only merge after the Eden upgrade is live.
FYI you will probably have to rebase your branch because #588 will get in before the 23.0 upgrade on Mainnet. |
4bf9d6d
to
5580b9f
Compare
57230ed
to
c4ebc8a
Compare
-d '{ | ||
"network_identifier": { | ||
"blockchain": "Oasis", | ||
"network": "b11b369e0da5bb230b220127f5e7b242d385ef8c6f54906243f30af63c815535" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mention that this is the chain context and where to look it up (links for mainnet and testnet). Also we should update the example after the Eden upgrade to include the new chain context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
d7dce79
to
384c915
Compare
We can merge this now since we're also updating the configs. |
384c915
to
ba13e12
Compare
ba13e12
to
de5bff9
Compare
State sync config is simplified in v23.x, specifying node addresses is not needed anymore.
Note: due to an unrelated libp2p issue (to be fixed) this currently doesn't work on testnet.
Wait with merging until after Eden upgrade.