Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23.0: docs/state-sync: Update state sync docs #620

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Nov 18, 2023

State sync config is simplified in v23.x, specifying node addresses is not needed anymore.

Note: due to an unrelated libp2p issue (to be fixed) this currently doesn't work on testnet.


Wait with merging until after Eden upgrade.

@ptrus ptrus requested review from matevz and kostko November 18, 2023 19:47
Copy link

netlify bot commented Nov 18, 2023

Deploy Preview for trusting-archimedes-14c863 ready!

Name Link
🔨 Latest commit de5bff9
🔍 Latest deploy log https://app.netlify.com/sites/trusting-archimedes-14c863/deploys/65664bb0e22337000881cb27
😎 Deploy Preview https://deploy-preview-620--trusting-archimedes-14c863.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, make sure to only merge after the Eden upgrade is live.

@matevz
Copy link
Member

matevz commented Nov 20, 2023

FYI you will probably have to rebase your branch because #588 will get in before the 23.0 upgrade on Mainnet.

@ptrus ptrus force-pushed the ptrus/feature/update-state-sync branch 3 times, most recently from 4bf9d6d to 5580b9f Compare November 27, 2023 08:48
@ptrus ptrus force-pushed the ptrus/feature/update-state-sync branch 2 times, most recently from 57230ed to c4ebc8a Compare November 27, 2023 08:56
-d '{
"network_identifier": {
"blockchain": "Oasis",
"network": "b11b369e0da5bb230b220127f5e7b242d385ef8c6f54906243f30af63c815535"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention that this is the chain context and where to look it up (links for mainnet and testnet). Also we should update the example after the Eden upgrade to include the new chain context.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@ptrus ptrus force-pushed the ptrus/feature/update-state-sync branch 2 times, most recently from d7dce79 to 384c915 Compare November 27, 2023 09:50
@kostko
Copy link
Member

kostko commented Nov 28, 2023

We can merge this now since we're also updating the configs.

@ptrus ptrus force-pushed the ptrus/feature/update-state-sync branch from 384c915 to ba13e12 Compare November 28, 2023 20:20
@ptrus ptrus marked this pull request as ready for review November 28, 2023 20:20
@ptrus ptrus force-pushed the ptrus/feature/update-state-sync branch from ba13e12 to de5bff9 Compare November 28, 2023 20:21
@ptrus ptrus enabled auto-merge November 28, 2023 20:21
@ptrus ptrus merged commit 3392d8f into main Nov 28, 2023
2 checks passed
@ptrus ptrus deleted the ptrus/feature/update-state-sync branch November 28, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants