Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/archive: fix runtime queries on archive nodes #5622

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Apr 2, 2024

TODO: Also backport to 22.2.x

Fix runtime queries on archive nodes. Also adds a runtime query to the archive_api E2E test.

Runtime queries are failing on archive due to the CurrentBlock not being set in the common node.

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 30cb4df
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/660e71e90379300008d21cba

@ptrus ptrus marked this pull request as draft April 2, 2024 17:03
@ptrus ptrus force-pushed the ptrus/fix/archive-queries-runtime branch from 05a287c to 84d2e47 Compare April 3, 2024 07:58
@ptrus ptrus force-pushed the ptrus/fix/archive-queries-runtime branch 2 times, most recently from c142642 to 13fae23 Compare April 3, 2024 08:22
go/consensus/cometbft/full/archive.go Outdated Show resolved Hide resolved
go/consensus/cometbft/full/archive.go Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/fix/archive-queries-runtime branch 2 times, most recently from 364b969 to e176261 Compare April 4, 2024 07:39
@ptrus ptrus marked this pull request as ready for review April 4, 2024 07:39
@ptrus ptrus force-pushed the ptrus/fix/archive-queries-runtime branch from e176261 to 256a76d Compare April 4, 2024 07:40
@ptrus ptrus force-pushed the ptrus/fix/archive-queries-runtime branch from 256a76d to 30cb4df Compare April 4, 2024 09:24
@ptrus ptrus enabled auto-merge April 4, 2024 09:37
@ptrus ptrus merged commit 5325cb6 into master Apr 4, 2024
3 checks passed
@ptrus ptrus deleted the ptrus/fix/archive-queries-runtime branch April 4, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants