Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Truffle support from TS client #191

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Remove Truffle support from TS client #191

merged 4 commits into from
Oct 20, 2023

Conversation

aefhm
Copy link
Contributor

@aefhm aefhm commented Sep 25, 2023 •
edited
Loading

Description

Consensys is sunsetting Truffle.

Unblock #173 and dependent on oasisprotocol/docs#547

@aefhm aefhm changed the title Remove Truffle support from TS client [CU-8692tfk9k] Remove Truffle support from TS client Sep 25, 2023
@aefhm aefhm changed the title [CU-8692tfk9k] Remove Truffle support from TS client Remove Truffle support from TS client Sep 25, 2023
@aefhm aefhm self-assigned this Sep 26, 2023
@aefhm aefhm added p:1 Priority: high dependencies Pull requests that update a dependency file js labels Sep 26, 2023
@aefhm aefhm force-pushed the xz/remove-truffle branch 2 times, most recently from 19b84be to f0833cc Compare September 26, 2023 16:10
@aefhm aefhm marked this pull request as ready for review September 26, 2023 19:17
@aefhm aefhm requested review from CedarMist and matevz September 26, 2023 19:33
@matevz matevz mentioned this pull request Sep 27, 2023
Merged
1 task
matevz
matevz requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also delete examples/truffle.

nhynes
nhynes approved these changes Sep 27, 2023
View reviewed changes
examples/truffle/package.json Outdated Show resolved Hide resolved
@aefhm aefhm force-pushed the xz/remove-truffle branch from 602331b to 0cd2f5e Compare October 2, 2023 20:34
@aefhm aefhm requested a review from matevz October 2, 2023 20:37
@matevz
Copy link
Member

matevz commented Oct 3, 2023

oasisprotocol/docs#547 should be merged before truffle removal.

@aefhm aefhm added blocked Pull requests that are blocked by another issue and removed blocked Pull requests that are blocked by another issue labels Oct 3, 2023
@aefhm aefhm force-pushed the xz/remove-truffle branch from 0cd2f5e to d862d5c Compare October 4, 2023 16:20
@aefhm
Copy link
Contributor Author

aefhm commented Oct 5, 2023

I think this PR is ready for next major release. 🙏

cc @matevz

matevz
matevz requested changes Oct 6, 2023
View reviewed changes
clients/js/src/compat.ts Show resolved Hide resolved
@aefhm aefhm force-pushed the xz/remove-truffle branch 3 times, most recently from 6e834ce to 1bad131 Compare October 10, 2023 16:19
@aefhm aefhm requested a review from matevz October 10, 2023 16:36
matevz
matevz approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested demo-voting with MetaMask using the new client and everything seems to work. Good job.

@aefhm aefhm force-pushed the xz/remove-truffle branch 2 times, most recently from 3d0bcda to ee9bd1e Compare October 18, 2023 23:43
@aefhm aefhm force-pushed the xz/remove-truffle branch from ee9bd1e to cb2cead Compare October 20, 2023 15:27
@aefhm aefhm enabled auto-merge October 20, 2023 15:27
@aefhm aefhm merged commit d1932bc into main Oct 20, 2023
13 of 14 checks passed
@aefhm aefhm deleted the xz/remove-truffle branch October 20, 2023 15:32
github-actions bot added a commit that referenced this pull request Oct 20, 2023
@github-actions
Deploy sol API reference Merge pull request #191 from oasisprotocol/x…
1b71411 
…z/remove-truffle

Remove Truffle support from TS client d1932bc
github-actions bot added a commit that referenced this pull request Oct 20, 2023
@github-actions
Deploy js API reference Merge pull request #191 from oasisprotocol/xz…
2ab4277 
…/remove-truffle

Remove Truffle support from TS client d1932bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhynes nhynes nhynes approved these changes

@matevz matevz matevz approved these changes

@CedarMist CedarMist Awaiting requested review from CedarMist

Assignees

@aefhm aefhm

Labels
dependencies Pull requests that update a dependency file p:1 Priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aefhm @matevz @nhynes @CedarMist