examples/onchain-signer/test: Add support for Sapphire Testnet/Mainnet #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedarMist
force-pushed
the
matevz/fix/onchain-signer-networks
branch
from
e36ac06 to
be85b2c
Compare
|
I made some minor changes to the Gasless contract to simplify it, the tests pass locally and on testnet. There are 2 problems:
To add back in the |
CedarMist
added
p:1
CedarMist
approved these changes
Oct 19, 2023
CedarMist
force-pushed
the
matevz/fix/onchain-signer-networks
branch
from
4c8f024 to
f5c3a72
Compare
matevz
commented
Oct 20, 2023
| // Proxy for gasless transaction. | ||
| contract Gasless { | ||
| EthereumKeypair private kp; | ||
|
|
||
| function setKeypair(EthereumKeypair memory keypair) external payable { | ||
| constructor (EthereumKeypair memory keypair) payable { |
There was a problem hiding this comment.
Contract create transactions are usually unencrypted for verification, so that's why I decided to have the setKeypair setter.
| nonce: ethers.provider.getTransactionCount(wallet1.address), | ||
| }), | ||
| ).not.to.be.reverted; | ||
| // NOTE can be done by the contract with EthereumUtils.generateKeypair() |
There was a problem hiding this comment.
// NOTE: Can be done by the contract with EthereumUtils.generateKeypair().
| const tx = await gasless.makeProxyTx(commentBox.address, innercall); | ||
|
|
||
| const plainResp = await gasless.provider.sendTransaction(tx); | ||
| const receipt = await ethers.provider.waitForTransaction(plainResp.hash); | ||
| // TODO: https://github.com/oasisprotocol/sapphire-paratime/issues/179 |
| @@ -9,22 +9,15 @@ struct EthereumKeypair { | |||
| uint64 nonce; | |||
| } | |||
|
|
|||
| struct EthTx { | |||
There was a problem hiding this comment.
Should we rename EIP155Signer.EthTx to EIP155Signer.Tx or EIP155Signer.Transaction?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes examples/onchain-signer tests actually pass on sapphire-testnet.
Merge after #175 since we use the wrapped provider for gasless tx.