Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts: add SHA384 hash and P-384 curve #217

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

CedarMist
Copy link
Member

Have tested this against sapphire-dev from oasisprotocol/oasis-web3-gateway#469

@CedarMist CedarMist requested review from matevz and aefhm October 26, 2023 20:47
@CedarMist CedarMist self-assigned this Oct 26, 2023
@CedarMist CedarMist added the contracts Pull requests that update sapphire-contracts label Oct 28, 2023
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some docs suggestions from my side. Otherwise looks good.

contracts/contracts/Sapphire.sol Show resolved Hide resolved
contracts/contracts/Sapphire.sol Show resolved Hide resolved
@matevz
Copy link
Member

matevz commented Oct 30, 2023

The new precompile should also be added to https://github.com/oasisprotocol/docs/blob/main/docs/dapp/sapphire/precompiles.md

@CedarMist CedarMist force-pushed the CedarMist/sha384-p384 branch from 50a4729 to d2711cc Compare October 30, 2023 20:55
@CedarMist CedarMist force-pushed the CedarMist/sha384-p384 branch from d2711cc to 56b1f3e Compare October 31, 2023 08:32
@CedarMist CedarMist merged commit fcd5102 into main Oct 31, 2023
13 checks passed
@CedarMist CedarMist deleted the CedarMist/sha384-p384 branch October 31, 2023 09:10
github-actions bot added a commit that referenced this pull request Oct 31, 2023
…edarMist/sha384-p384

contracts: add SHA384 hash and P-384 curve fcd5102
github-actions bot added a commit that referenced this pull request Oct 31, 2023
…darMist/sha384-p384

contracts: add SHA384 hash and P-384 curve fcd5102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Pull requests that update sapphire-contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants