Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish JS client 1.2.0 #221

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Publish JS client 1.2.0 #221

merged 2 commits into from
Dec 1, 2023

Conversation

aefhm
Copy link
Contributor

@aefhm aefhm commented Nov 6, 2023

Description

Draft PR for next client version until #223

TODO

@aefhm aefhm self-assigned this Nov 6, 2023
@aefhm aefhm added blocked Pull requests that are blocked by another issue p:1 Priority: high js client labels Nov 6, 2023
@aefhm aefhm force-pushed the aefhm-patch-1 branch 2 times, most recently from 3fa8768 to 8aec05b Compare November 13, 2023 04:16
@aefhm aefhm marked this pull request as ready for review November 13, 2023 04:16
@CedarMist
Copy link
Member

When package upgrades are available in GitHub for NPM packages, it will show a changelog on dependabot. How does that work?

@aefhm
Copy link
Contributor Author

aefhm commented Nov 13, 2023

changelog on dependabot.

Dependabot queries on a cadence or change and fetches release notes etc for the relevant version bumps.

I'm not sure if our usage of tags will get picked up appropriately. Uhh, lemme check.

I'm reading your question as in that we desire for projects with a dependency of @oasisprotocol/sapphire-paratime to have easy integrations with our JS client which I agree with.

@aefhm
Copy link
Contributor Author

aefhm commented Nov 14, 2023

Ugh, verdict is not great in this test repo.

image

I think our usage of the namespaced tags may be inconsistent with dependabot expectations. This example retrieves commits as expected.

Edit. dependabot has a release tag querying regex which I'd guess we are probably escaping...

@aefhm aefhm requested a review from CedarMist November 15, 2023 17:32
@CedarMist CedarMist merged commit 05899ee into main Dec 1, 2023
13 checks passed
@CedarMist CedarMist deleted the aefhm-patch-1 branch December 1, 2023 09:25
github-actions bot added a commit that referenced this pull request Dec 1, 2023
github-actions bot added a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Pull requests that are blocked by another issue client p:1 Priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants