Hardhat: Use sapphire and sapphire-testnet for network names #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matevz
force-pushed
the
matevz/fix/hardhat-network-names
branch
from
fe5d27c to
aca5fa4
Compare
aefhm
approved these changes
Nov 21, 2023
Makes sense. |
matevz
force-pushed
the
matevz/fix/hardhat-network-names
branch
from
aca5fa4 to
874f86a
Compare
matevz
force-pushed
the
matevz/fix/hardhat-network-names
branch
from
874f86a to
dfc59fa
Compare
github-actions bot
added a commit
that referenced
this pull request
Nov 21, 2023
…atevz/fix/hardhat-network-names Hardhat: Use sapphire and sapphire-testnet for network names 9fdd2bb
github-actions bot
added a commit
that referenced
this pull request
Nov 21, 2023
…tevz/fix/hardhat-network-names Hardhat: Use sapphire and sapphire-testnet for network names 9fdd2bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Hardhat network names consistent with the ones that are registered in the Ethereum chain list. This is currently:
In the future, we may want to register
sapphire-localnetandemerald-localnetas well, rename the docker image fromsapphire-dev->sapphire-localnetand update the contracts CI scripts accordingly.