Refactor callDataPublicKey handling #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubej
reviewed
Feb 6, 2024
github-actions bot
added a commit
that referenced
this pull request
Feb 6, 2024
…darMist/calldatapublickey-expire Refactor callDataPublicKey handling cfc6eeb
github-actions bot
added a commit
that referenced
this pull request
Feb 6, 2024
…edarMist/calldatapublickey-expire Refactor callDataPublicKey handling cfc6eeb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix several long-standing issues with call encryption.
Previously the
Cipherobject would be created and maintained with the same keys throughout the duration of the session, it also did not support the newEpochflag which specifies which calldata public key was being used to encrypt the request (requiring the server to try several).This would cause problems, like when you leave a dApp open for a while your transactions would fail with 'tag verification failed'.
This introduces several changes:
epochparameter is passed in the encryption envelopescripts/proxy.jsshows epoch status too.This means that leaving dApps open for prolonged periods of time will be OK.
Follow-up notes:
contracts/had a small rewrite, because of the variance they were longer a sufficient test of what they were supposed to do check for! They've been made relative instead.