Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrations/wagmi: initial re-work of wagmi support #292
integrations/wagmi: initial re-work of wagmi support #292
Changes from 15 commits
ada5a12
2f3c44d
881c8f6
66e41e3
3547e56
9b67e2d
72ed436
195e537
2155379
01f81dd
64afe5d
7511296
bd3ce31
372fe95
3adfc65
6045522
ad207a2
77fe9c6
5edc5a6
30d0a52
4143067
4ca20e2
862aa35
9f9bfac
ee112fd
241d339
11e75ea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there some kind of utility function for this already.
isEip1193Provider
which returns the correct typed provider. If not, please create one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'request' in provider
is shorter and more explicit thanisEip1193Provider(provider)
I have a refactor waiting in my head that removes this messiness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above, will also solve this any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't solve this
any
instance, thesend
interface is exposed byJsonRpcProvider
andBrowserProvider
, but this could be from ether the Ethers 5 or Ethers 6 packages.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe update this README here? To something like Wagmi example, or just delete the README.