-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment pattern recommendations #313
Conversation
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
7abfd04
to
7b499ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should rather rename the chapter to upgradable.md
? I can't get rid of a feeling that the chapter is about setting up oracles or paymasters or proxy nodes at first glance when I see the "Proxies" title. The "Upgradable Contracts" is the title I think it rings the right bell for firstcomers.
I kind of want to 🤔. I hear you on the notion of proxy nodes. My concern with "Upgradeable Contracts" would be that the deterministic deploys are "Clones" so to speak with regards to OpenZeppelin terminology. Perhaps "Deployment Customization" or "Upgradable and Deterministic Contracts" can unify both sections? Or how about "Deployment Patterns?" |
cd7694a
to
3b41816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
3b41816
to
26a3200
Compare
26a3200
to
f7a4bf6
Compare
Description
Add technical notes on proxies.
Relates to oasisprotocol/docs#818.