Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Jonathan Neuteboom committed Jan 7, 2025
1 parent dc12e35 commit 7c62bc2
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 19 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@observation.org/react-native-components",
"version": "1.49.0",
"version": "1.50.0",
"main": "src/index.ts",
"repository": "[email protected]:observation/react-native-components.git",
"author": "Observation.org",
Expand Down Expand Up @@ -55,7 +55,7 @@
},
"dependencies": {
"@fortawesome/fontawesome-svg-core": "^6.6.0",
"@fortawesome/free-brands-svg-icons": "^6.7.2",
"@fortawesome/free-brands-svg-icons": "6.6.0",
"@fortawesome/pro-light-svg-icons": "^6.6.0",
"@fortawesome/pro-solid-svg-icons": "^6.6.0",
"@fortawesome/react-native-fontawesome": "^0.3.2",
Expand Down
3 changes: 1 addition & 2 deletions src/components/BrandIcon.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react'

import { IconProp } from '@fortawesome/fontawesome-svg-core'
import { FontAwesomeIcon } from '@fortawesome/react-native-fontawesome'

import BrandIcons, { BrandIconName } from '../lib/BrandIcons'
Expand All @@ -17,7 +16,7 @@ const BrandIcon = ({ name, color, size }: Props) => {
const iconColor = color ?? theme.color.primary
const iconSize = size ?? theme.icon.size.large

return <FontAwesomeIcon icon={icon as IconProp} color={iconColor} size={iconSize} />
return <FontAwesomeIcon icon={icon} color={iconColor} size={iconSize} />
}

export default BrandIcon
4 changes: 2 additions & 2 deletions src/lib/BrandIcons.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { IconName as FontawesomeIconName } from '@fortawesome/fontawesome-svg-core'
import { IconName } from '@fortawesome/fontawesome-svg-core'
import { IconDefinition } from '@fortawesome/free-brands-svg-icons'
import { faWikipediaW } from '@fortawesome/free-brands-svg-icons/faWikipediaW'

type BrandIconName = Extract<FontawesomeIconName, 'wikipedia-w'>
type BrandIconName = Extract<IconName, 'wikipedia-w'>

const BrandIcons: { [key in BrandIconName]: IconDefinition } = {
'wikipedia-w': faWikipediaW,
Expand Down
19 changes: 6 additions & 13 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1725,13 +1725,6 @@ __metadata:
languageName: node
linkType: hard

"@fortawesome/fontawesome-common-types@npm:6.7.2":
version: 6.7.2
resolution: "@fortawesome/fontawesome-common-types@npm:6.7.2::__archiveUrl=https%3A%2F%2Fnpm.fontawesome.com%2F%40fortawesome%2Ffontawesome-common-types%2F-%2F6.7.2%2Ffontawesome-common-types-6.7.2.tgz"
checksum: 9c17f03032e56b8e8e996e5b2c15c8b47baf6f8d5c0703025b0b2711907245f94a7032b3da52d2714b5aeff1c14d3535e6869a82086136dcacae9ccd479dc6a2
languageName: node
linkType: hard

"@fortawesome/fontawesome-svg-core@npm:^6.6.0":
version: 6.6.0
resolution: "@fortawesome/fontawesome-svg-core@npm:6.6.0::__archiveUrl=https%3A%2F%2Fnpm.fontawesome.com%2F%40fortawesome%2Ffontawesome-svg-core%2F-%2F6.6.0%2Ffontawesome-svg-core-6.6.0.tgz"
Expand All @@ -1741,12 +1734,12 @@ __metadata:
languageName: node
linkType: hard

"@fortawesome/free-brands-svg-icons@npm:^6.7.2":
version: 6.7.2
resolution: "@fortawesome/free-brands-svg-icons@npm:6.7.2::__archiveUrl=https%3A%2F%2Fnpm.fontawesome.com%2F%40fortawesome%2Ffree-brands-svg-icons%2F-%2F6.7.2%2Ffree-brands-svg-icons-6.7.2.tgz"
"@fortawesome/free-brands-svg-icons@npm:6.6.0":
version: 6.6.0
resolution: "@fortawesome/free-brands-svg-icons@npm:6.6.0::__archiveUrl=https%3A%2F%2Fnpm.fontawesome.com%2F%40fortawesome%2Ffree-brands-svg-icons%2F-%2F6.6.0%2Ffree-brands-svg-icons-6.6.0.tgz"
dependencies:
"@fortawesome/fontawesome-common-types": 6.7.2
checksum: 1583c684e3070952ae392dcb1a6f8a3af3637b8030f2aa2a7305f09150d957493ac2e22d29fd45c801d7166c28200a8d1fc92d67b6aa528e9a3f9715b24a8e95
"@fortawesome/fontawesome-common-types": 6.6.0
checksum: f2bcddb9e88860e459d68bdcb0100a98f7e9fd56325bb66d4c7328b3e4191c67734bee0fea8fe739c51602e1a93e5418f7542279a9f38271cf1dc3a9f6e8e099
languageName: node
linkType: hard

Expand Down Expand Up @@ -2523,7 +2516,7 @@ __metadata:
"@eslint/eslintrc": ^3.1.0
"@eslint/js": ^9.11.1
"@fortawesome/fontawesome-svg-core": ^6.6.0
"@fortawesome/free-brands-svg-icons": ^6.7.2
"@fortawesome/free-brands-svg-icons": 6.6.0
"@fortawesome/pro-light-svg-icons": ^6.6.0
"@fortawesome/pro-solid-svg-icons": ^6.6.0
"@fortawesome/react-native-fontawesome": ^0.3.2
Expand Down

0 comments on commit 7c62bc2

Please sign in to comment.