Environment variable configuration #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squat
reviewed
Oct 15, 2021
jpweber
force-pushed
the
environment-variable-configuration
branch
2 times, most recently
from
41a13fa to
027a87c
Compare
…ast touched. Signed-off-by: Jim Weber <[email protected]>
|
Reviving a Zombie. I have pushed updates to this PR to bring it inline with the current state of the project. |
squat
reviewed
Feb 27, 2024
main.go
Outdated
| @@ -70,28 +70,47 @@ type oidcConfig struct { | |||
| password string | |||
| } | |||
|
|
|||
| func LookupEnvOrString(key string, defaultVal string) string { | |||
There was a problem hiding this comment.
Can we please make all of these lowercase, ie non-exported functions? That's the standard for Go and for the Observatorium project if they are only used internally
There was a problem hiding this comment.
Changes have been made and pushed.
squat
requested changes
Feb 27, 2024
Signed-off-by: Jim Weber <[email protected]>
Very welcome. Thanks for reviewing. |
|
|
|
wooo! @astro-walker done :)) |
|
Amazing thanks for the fast response 🙏 |
|
3+ years, feels good. |
|
ToT we try to keep this project moving at the speed of enterprise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
we wanted to be able to use environment variables to drive some of the configuration instead of just args. let me know if this works for you, or if we need to add more to this PR to get it merged.
thanks!