Skip to content

Commit

Permalink
windows: Fix check32bitOn64bit
Browse files Browse the repository at this point in the history
For OBS Studio 29.1.0-beta1, 64-bit OBS did not output "64-bit" in its
logs. While this was fixed for OBS Studio 29.1.0-beta2, the check as it
is currently would probably also catch a hypothetical native WoA
(Windows-on-ARM) build. Additionally, the change in this commit is what
the live log analyzer has been running for about a year. Checking for
the presence of the undesired indicator ("32-bit" or "32bit") seems more
correct than checking for the absence of the desired indicator ("64-bit"
or "64bit").
  • Loading branch information
RytoEX committed Mar 25, 2024
1 parent efa34ab commit 770e2ea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion checks/windows.py
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ def checkAdmin(lines):
def check32bitOn64bit(lines):
winVersion = search('Windows Version', lines)
obsVersion = getOBSVersionLine(lines)
if (len(winVersion) > 0 and '64-bit' in winVersion[0] and '64-bit' not in obsVersion and '64bit' not in obsVersion):
if (len(winVersion) > 0 and '64-bit' in winVersion[0] and ('32-bit' in obsVersion or '32bit' in obsVersion)):
# thx to secretply for the bugfix
return [LEVEL_WARNING, "32-bit OBS on 64-bit Windows",
"You are running the 32 bit version of OBS on a 64 bit system. This will reduce performance and greatly increase the risk of crashes due to memory limitations. You should only use the 32 bit version if you have a capture device that lacks 64 bit drivers. Please run OBS using the 64-bit shortcut."]
Expand Down

0 comments on commit 770e2ea

Please sign in to comment.