Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: Fix duplicate entries in checkMacPermissions #172

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

prgmitchell
Copy link
Member

Description

Replace the deniedPermissions list with a set to remove duplicates.

Motivation and Context

Was tagged in the Discord server letting me know of this issue with reference to this log:
https://obsproject.com/logs/OD7NWhVvisp9UU1G

How Has This Been Tested?

Confirmed the analyzer no longer shows duplicate permission entries for that log.
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct commit prefix is probably macos: since this only modifies that file.

Replace the deniedPermissions list with a set to remove duplicates.
@prgmitchell prgmitchell changed the title checks: Fix duplicate entries in checkMacPermissions macos: Fix duplicate entries in checkMacPermissions Nov 23, 2024
@prgmitchell
Copy link
Member Author

The correct commit prefix is probably macos: since this only modifies that file.

Updated

Copy link
Member

@Fenrirthviti Fenrirthviti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RytoEX RytoEX merged commit 83177fb into obsproject:master Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants