Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Expose detected plugin name to other workflow jobs #109

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

PatTheMav
Copy link
Member

Description

Adds early detection of the configured plugin name in workflows so the name can be re-used in later workflows without the need to do a full repository checkout or installation of 3rd party utilities (e.g. the release creation step).

Motivation and Context

Reduce necessary fixup steps for plugin developers when finalising their releases.

Fixes #105.

How Has This Been Tested?

Tested with a tagged release on a fork of the repository.

Types of changes

  • Performance enhancement (non-breaking change which improves efficiency)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

.github/workflows/build-project.yaml Outdated Show resolved Hide resolved
@PatTheMav PatTheMav force-pushed the fix-release-title branch 2 times, most recently from e70c9f2 to b4b38a8 Compare December 16, 2023 17:13
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@CodeYan01
Copy link

With the new displayName change, have you tested creating a new release, with a space in the displayName? I am getting an error: https://github.com/CodeYan01/media-playlist-source/actions/runs/7257209427/job/19770748632

@PatTheMav
Copy link
Member Author

With the new displayName change, have you tested creating a new release, with a space in the displayName? I am getting an error: https://github.com/CodeYan01/media-playlist-source/actions/runs/7257209427/job/19770748632

Right, it's not supposed to be used for file names now that it can have spaces and other weird characters in it, forgot to remove that again.

@PatTheMav
Copy link
Member Author

@CodeYan01 pls check again.

@CodeYan01
Copy link

In the Issue, you commented that it will fallback to name if displayName is not available, but I'm getting an error when the field is not there. https://github.com/CodeYan01/media-playlist-source/actions/runs/7284773565

With the displayName it now works perfectly. https://github.com/CodeYan01/media-playlist-source/actions/runs/7284781779

Thank you!

@PatTheMav
Copy link
Member Author

In the Issue, you commented that it will fallback to name if displayName is not available, but I'm getting an error when the field is not there. https://github.com/CodeYan01/media-playlist-source/actions/runs/7284773565

With the displayName it now works perfectly. https://github.com/CodeYan01/media-playlist-source/actions/runs/7284781779

Thank you!

Ah, good old pipefail, should be fixed in a bit.

@CodeYan01
Copy link

Tested both cases, works now.

@PatTheMav PatTheMav merged commit bebefd4 into obsproject:master Dec 21, 2023
6 checks passed
@PatTheMav PatTheMav deleted the fix-release-title branch December 21, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Created release does not use plugin name
3 participants