Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Move common variables to an inherited preset #111

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Jan 10, 2024

Description

Move ENABLE_FRONTEND_API and ENABLE_QT from individual presets to a common preset that is hidden but inherited by the individual presets.

Motivation and Context

Generally, these will have the same values on all platforms. Make it easier for plugin devs to enable or disable Frontend API and Qt for all presets/platforms.

Devs can still override this per preset if needed by simply setting a different value in an individual preset.

Fixes #103

How Has This Been Tested?

Haven't tested locally. CI should be able to test.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Move ENABLE_FRONTEND_API and ENABLE_QT from individual presets to a
common preset that is hidden but inherited by the individual presets.
@RytoEX RytoEX requested a review from PatTheMav January 10, 2024 05:24
@RytoEX RytoEX merged commit 42c8b4f into obsproject:master Jan 10, 2024
6 checks passed
@RytoEX RytoEX deleted the refactor-common-preset-vars branch January 10, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMakePresets.json should have a single definition for ENABLE_FRONTEND_API and ENABLE_QT
2 participants