Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Footnote Support #309

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add Footnote Support #309

wants to merge 9 commits into from

Conversation

onsah
Copy link

@onsah onsah commented Oct 8, 2024

I use omd for my personal static site generator and I am very happy with it (thank you very much!). I wanted to use footnotes so I created this PR. It's my first time working on this project, so I would welcome any feedback.

Footnote support is based on https://www.markdownguide.org/extended-syntax/#footnotes. As far as I see CommonMark doesn't specify footnotes.

Screenshots

Example screenshots for the feature from my page
Screenshot from 2024-10-09 11-42-03
Screenshot from 2024-10-09 11-42-21

[^footnote]: link
.
<p><sup><a href="#fn:footnote" id="fnref:footnote">footnote</a></sup></p>
<div class="footnotes"><hr /><ol><li id="fn:footnote"><p>link<a href="#fnref:footnote">↩</a>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Added footnotes class to the footnotes section so one can style it as they wish.
  • hr separates the footnote content from the rest of the document.

@onsah onsah marked this pull request as ready for review October 8, 2024 15:55
@onsah onsah changed the title Footnotes Add Footnote Support Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant