-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(homepage): project card refinement #298
Conversation
✅ Deploy Preview for openstartervillage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for openstartervillage-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Very nice proof of concept idea. I think we should consider these two methods to make this pull request better.
|
1214340
to
c9734f7
Compare
The Card component renders ProjectCard and non-ProjectCard differently. The naming of those files are confusing. Please extract out the ProjectCard JSX to be The pseudo code in const Card = (props) => {
if (props.data.type === 'project_card') {
return <ProjectCard {...props} />
}
return <DefaultCard {...props} />
} |
Yes, Sir! 🫡 |
…cy issue in avatarList
43e4dd3
to
d4d0a9e
Compare
Refine project card design
Major
minor
Impaction
Screenshots
Before
After
Performance
Build and deploy time