improve email composer #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ocodista
requested changes
Nov 30, 2023
apps/auto-email-sender/email-composer/src/test/filterRoles.spec.ts
Outdated
Show resolved
Hide resolved
…c.ts Co-authored-by: Caio Borghi <[email protected]>
ocodista
requested changes
Nov 30, 2023
ocodista
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, we improve the email composer service
Improvements
The render method of @react-email/render is very slow. To increase the speed of this service, we render one time and use this string to add roles or other dynamics info.
To improve speed, we memoize used roles for accessing mongoDb one time for each role.
Result
Now, the time of executing is 28.594s with 4 instances!