Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.0.4 #58

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Bump version to 1.0.4 #58

merged 2 commits into from
Jan 24, 2025

Conversation

tiran
Copy link
Contributor

@tiran tiran commented Jan 24, 2025

No description provided.

Signed-off-by: Christian Heimes <[email protected]>
@tiran
Copy link
Contributor Author

tiran commented Jan 24, 2025

The 1.0.3 tag has Cargo.toml with package version 1.0.2. The release action https://github.com/oconnor663/blake3-py/actions/runs/12948776393 did not upload the release to PyPI, because there is already a 1.0.2 release.

@tiran
Copy link
Contributor Author

tiran commented Jan 24, 2025

@ddelange please take a look

Cargo.toml Outdated
@@ -5,7 +5,7 @@
# PyPI. Installing this with `pip install blake3` is better than something
# redundant like `pip install PyBLAKE3-py`.
name = "blake3"
version = "1.0.2"
version = "1.0.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn, not the first time I forgot this. will push 1.0.4

Suggested change
version = "1.0.3"
version = "1.0.4"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too bad that Cargo doesn't support dynamic versions similar to Python's setuptools-scm hook. rust-lang/cargo#6583 has some suggestions, e.g. a build.rs hack. Maybe you could depend on setuptools-scm and shell out to setuptools-scm in build.rs? The Python tool gets its version from SCM and falls back to PKG-INFO file for sdists.

@ddelange ddelange changed the title Bump version to 1.0.3 Bump version to 1.0.4 Jan 24, 2025
@ddelange ddelange merged commit be76652 into oconnor663:master Jan 24, 2025
135 checks passed
@ddelange
Copy link
Collaborator

1.0.4 is now on PyPI. thanks for your PRs!

@tiran tiran deleted the bump-1.0.3 branch January 24, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants