-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and cleanup projects #304
base: main
Are you sure you want to change the base?
Conversation
* Update test projects from .NET Core 3.1 (out of support) to .NET 6 (LTS) * Remove `<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />` (see microsoft/vstest#472 (comment)) * Remove `<LangVersion>7.2</LangVersion>` on test projects * Fix `Run_Specifies_Cancellation_Token` which (rightfully) throws when running on .NET 6
I'm interested in picking this up, as I'm looking at #312 but also want to update other aspects of the library. To avoid stomping on your branch/fork any further, I'll create a separate PR. |
@Lamparter i think we've already worked this in our PR right? |
Yes I think so. I definitely did do 1st (obviously) and I remember fixing the 4th task also. But not sure whether or not I implemented 2nd and 3rd.
|
#321 supersedes this PR, @Lamparter we seem to haven't implemented the 4th and sounds like we should separate. |
Separate? |
Instead of including that change in #321 |
Where would we include that change instead? |
A new PR or here (with other changes reverted as superseded by our PR). |
This isn't our pr though. I think it's best to just leave in one pr. |
<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
(see Test projects end up with this GUID microsoft/vstest#472 (comment))<LangVersion>7.2</LangVersion>
on test projectsRun_Specifies_Cancellation_Token
which (rightfully) throws when running on .NET 6