docs: improve the odigos architecture components page #2232
+60
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Sorry for the massive review
It would be good to decide on some style guidelines for consistency. Some things I noticed here:
- Capitalizing Odigos components and features. Things like Actions, Sources, Autoscaler, Instrumetor, Odiglet, Node Collector, etc. We should be consistent about when these are capitalized
- On that note, using "the" before Odigos components -- do we thing things like Instrumentor should be "the Instrumentor" or just "Instrumentor"? I guess it depends on the context
- Using "k8s"/"Kubernetes" -- the latter is more formal so I think we should stick to it as much as possible
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
Co-authored-by: Mike Dame <[email protected]>
damemi
approved these changes
Jan 15, 2025
Thanks! will merge it and we can chat sometimes about what "pipeline" means in odigos and revisit this docs page to align |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.