feat: add config option for mount method hostpath or virtual device #2459
Conversation
| @@ -0,0 +1,94 @@ | |||
| --- | |||
| title: "Agent Mount Method" | |||
There was a problem hiding this comment.
What do you think about:
Agent Injection ModeInstrumentation Mode
There was a problem hiding this comment.
I think injection and instrumentaiton can mean many things. mount makes what this option is for explicit.
I am open to hearing alternatives
There was a problem hiding this comment.
I thought to abstract it for the user, basically the mount used to inject the agent for languages that needed.
I feel like Agent mount is not clear, but maybe lets hear another opinion
| @@ -69,6 +70,17 @@ func (p *PodsWebhook) Default(ctx context.Context, obj runtime.Object) error { | |||
| return nil | |||
| } | |||
|
|
|||
| odigosConfig, err := k8sutils.GetCurrentOdigosConfig(ctx, p.Client) | |||
There was a problem hiding this comment.
is it possible to take it to other func
verifyAgentInjectionModeSet so it will be more clear ?
There was a problem hiding this comment.
It's not only verifying the value but also fetching it to be used by injectOdigosToContainer.
Not sure I understand what you are suggesting.
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Tamir David <[email protected]>
Co-authored-by: Tamir David <[email protected]>
|
|
||
| If it is supported in the cluster, it is preferred to use over the VirtualDevice method which requires odiglet component to run. | ||
|
|
||
| #### Enabling VirtualDevice |
There was a problem hiding this comment.
| #### Enabling VirtualDevice | |
| #### Enabling HostPath |
|
|
||
| // amir 17 feb 2025, this is here only for migration. | ||
| // even if mount method is not device, we still need to inject the deprecated agent specific device | ||
| // while we remove them one by one | ||
| isGenericDevice := *distroMetadata.RuntimeAgent.Device == k8sconsts.OdigosGenericDeviceName | ||
| if mountMethod == common.K8sVirtualDeviceMountMethod || !isGenericDevice { | ||
| deviceName := *distroMetadata.RuntimeAgent.Device | ||
| // TODO: currently devices are composed with glibc as input for dotnet. | ||
| // as devices will soon converge to a single device, I am hardcoding the logic here, | ||
| // which will eventually be removed once dotnet specific devices are removed. | ||
| if containerConfig.DistroParams != nil { | ||
| libcType, ok := containerConfig.DistroParams[common.LibcTypeDistroParameterName] | ||
| if ok { | ||
| libcPrefix := "" | ||
| if libcType == string(common.Musl) { | ||
| libcPrefix = "musl-" | ||
| } |
There was a problem hiding this comment.
This code is getting hard to understand and follow,
we should probably refactor this a bit in follow ups
There was a problem hiding this comment.
Once we remove the devices from all remaining distros, it will be straight forward
|
Thanks @BenElferink addressed all your comments |
This allows the user to choose how to apply the mount.
k8s-host-pathwill add volume to the pod with "host-path".k8s-virtual-devicewill add the "instrumentation.odigos.io/generic" device to the resource part of relevant containers.This allows control of how the mounting is achieved.
Future work: auto detect if hostpath may fail and automatically fallback to virtual device.