Skip to content
This repository has been archived by the owner on May 5, 2021. It is now read-only.

[FIX] DomLayout: allow attribute with empty string #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FIX] DomLayout: allow attribute with empty string #240

wants to merge 1 commit into from

Conversation

Goaman
Copy link
Contributor

@Goaman Goaman commented Jul 7, 2020

No description provided.

@Goaman Goaman requested a review from dmo-odoo July 7, 2020 11:55
@dmo-odoo
Copy link
Collaborator

dmo-odoo commented Jul 8, 2020

I'm not sure this is right to end up with target="" when the user never set any target to begin with.

@Goaman
Copy link
Contributor Author

Goaman commented Jul 8, 2020

It is LinkFormat that has a constructor(url = '#', target = '').
Do I change LinkFormat?

@dmo-odoo
Copy link
Collaborator

dmo-odoo commented Jul 8, 2020

I would say yes but I'm curious for @Zinston's input here.

@dmo-odoo
Copy link
Collaborator

@Goaman Considering @Zinston did not reply and won't be working for some days, I would say yes.

@dmo-odoo dmo-odoo added the needs refactoring Extra renaming/refactoring is needed label Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dmo-odoo dmo-odoo Awaiting requested review from dmo-odoo

Assignees
No one assigned
Labels
needs refactoring Extra renaming/refactoring is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goaman @dmo-odoo