Improve variable conversion & comparison handling as well as CMake version compatibility #671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
quill
source code as part of a larger project can reveal points of improvement mainly pointed out by inherited compiler flags. Fixes include:3.31.5
) can reveal obsolete CMake policy incompatibility. Changing minimum version to3.10
alleviates these warnings. Worth noting that current version3.8
dates back to 2017.