Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header-comments cleanup. Unused includes cleanup #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

inobelar
Copy link
Contributor

@inobelar inobelar commented Aug 29, 2024

The reason for this 'cleanup' PR, is minor garbage in header-comments, due (as I can see) to project initially generated from template.

Changes:

  1. AUTHORS file moved from gst-h264-encryption directory to root
  2. COPYING in gst-h264-encryption directory removed, since exactly the same placed in root directory (so now its not duplicated)
  3. As header-comment used everywhere (except files of AES lib):
    /*
     * GStreamer H264 Encryption Plugin
     *
     * Copyright (C) 2024 Oguzhan Oztaskin <[email protected]>
     *
     * This program is free software: you can redistribute it and/or modify
     * it under the terms of the GNU General Public License as published by
     * the Free Software Foundation, either version 3 of the License, or
     * (at your option) any later version.
     *
     * This program is distributed in the hope that it will be useful,
     * but WITHOUT ANY WARRANTY; without even the implied warranty of
     * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     * GNU General Public License for more details.
     *
     * You should have received a copy of the GNU General Public License
     * along with this program.  If not, see <https://www.gnu.org/licenses/>.
     */
    • Since, as I can see, you choosed GPLv3. Template for it given from here
    • Inspired by GStreamer's small GPLv2 header comments, like in gstudp
  4. Removed unused includes in some places
  5. Some includes was annotated with #include <xxx.h> // for: yyy for clarity
  6. Improved readability of some 'include guards', for example: __GST_H264ENCRYPTIONBASEPRIVATE_H__ -> __GST_H264_ENCRYPTION_BASE_PRIVATE_H__
  7. Removed 'extra' semicolons in G_DEFINE_TYPE(...), GST_ELEMENT_REGISTER_DEFINE() macro
  8. Changed project name in meson.build from gst-template to gst-h264-encryption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant