Display only rows that fit screen to avoid vertical scroll

[guergana]

• fixes Is it possible to have DataGrid without vertical scroll? #204

Two open questions:

• do we need to update the pageSizes select as well to include the new size?
• do we want to extract the resizeEvent as an utility now or do we cross that bridge when we get to it? hehe.

---

Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

[guergana]

Do we leave the pageSizes as it is by default [5,10,15,20]? Or we adjust it as well according to the rows per page.
.
@roll @romicolman

[cloudflare-workers-and-pages]

Deploying opendataeditor with    Cloudflare Pages

Latest commit:	908665b
Status:	✅  Deploy successful!
Preview URL:	https://2e41837e.opendataeditor.pages.dev
Branch Preview URL:	https://204-datagrid-no-vertical-scr.opendataeditor.pages.dev

View logs

[romicolman]

Hey! Yes, please, leave it as it is right now.

[roll]

Hi @guergana, nice! I'm going to test it.

It seems to be that the changes from another PR leaked here BTW

[guergana]

Hi @guergana, nice! I'm going to test it.

It seems to be that the changes from another PR leaked here BTW

@roll You are right! That's a rebase gone wrong. But those changes have been merged into main already so it can still be tested. Will rebase again and push later when I am on the computer 🙈

[roll]

@guergana
Sure! No problem at all

[roll]

Wow, amazing! It works! 🎉

I agree that "Results per page" is a problem as if as a USER I change it I can't get back to "Fit the Screen" option. Possible solutions would be:

• removing "Results per page" completely
• adding "Fit the screen" option (if supported by the grid component)

If not handled in this PR I would create a new issue for it.

[guergana]

Wow, amazing! It works! 🎉

I agree that "Results per page" is a problem as if as a USER I change it I can't get back to "Fit the Screen" option. Possible solutions would be:

* removing "Results per page" completely

* adding "Fit the screen" option (if supported by the grid component)

If not handled in this PR I would create a new issue for i

[roll]

@guergana
I think it still counts my review but the automatic check requires the conversations to be resolved with the "Resolve" button:

[roll]

Usually, the PR author marks them resolved before merging as a double-check that the feedback is incorporated

[guergana]

@guergana
I think it still counts my review but the automatic check requires the conversations to be resolved with the "Resolve" button:

@roll Ah thanks. I am checking on the phone and it doesn't say anything about the resolve. It only says can't merge. Thanks for the screenshot.

[guergana]

Usually, the PR author marks them resolved before merging as a double-check that the feedback is incorporated

I see, until now my GitHub projects have been configured in a different way. For example, we had that the approvals were automatically dismissed if a commit was pushed after the approval. I didn't know even you could do it like this. Nice to see there's so much versatility in the configuration of GitHub merge options. Hehe. Thanks for the heads up @roll :)