-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
345 Remove bar next to the app name #372
Conversation
Deploying opendataeditor with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pdelboca
You know I consider any UI changes before actual user testing sessions and UX person arrives is way preliminary. For example, the status bar contains critical information to the user:
- file type
- selected file path
- a button to change the file type
- and the whole "Create" new functionality
Also, it generally degrades the visual design of the application designed to look familiar to the users with a search bar at the top as in many modern applications like browsers/etc
But the implementation of change itself looks fine 😄
@roll I know, but this simplifies and it was requested by the PO as she considers that the only element we should have in the top navigation bar is the Yes, I took a look at the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pdelboca
That's fine. My work is to share honest opinion but the PR itself looks good
Thanks @roll ! I appreciate your comments :) |
Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)