Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source view #389

Merged
merged 6 commits into from
May 20, 2024
Merged

Fix source view #389

merged 6 commits into from
May 20, 2024

Conversation

roll
Copy link
Collaborator

@roll roll commented May 14, 2024


Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

@roll roll requested a review from guergana May 14, 2024 13:46
@roll
Copy link
Collaborator Author

roll commented May 14, 2024

@guergana
Can you please review and test?

Copy link
Collaborator

@guergana guergana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roll , I am a bit confused about the source button in .json files. The button is active but the whole view of the article is a source, it's not a panel like in the others, but in the json it is editable and in the csv is read-only. Is this intentional? Also why have the source button active in the json file if there is no different source? This is more a product question I guess.

image

.github/workflows/general.yaml Show resolved Hide resolved
@roll
Copy link
Collaborator Author

roll commented May 20, 2024

@guergana
Currently, the purple controls indicate that they are activated (they are not clickable). In this case, we're in the source editing mode. It might be changed in the future

Copy link
Collaborator

@guergana guergana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks. I also tested the .*tsv and it works as expected

@roll roll merged commit 304937b into main May 20, 2024
8 checks passed
@roll roll deleted the 349/fix-source-button branch May 20, 2024 14:05
@pdelboca pdelboca mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source button
2 participants