Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backspace on key functionality for deleting of multiple cells #408

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

guergana
Copy link
Collaborator

Copy link

cloudflare-workers-and-pages bot commented May 27, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 379b3ba
Status: ✅  Deploy successful!
Preview URL: https://93719a6b.opendataeditor.pages.dev
Branch Preview URL: https://350-add-backspace-key-to-fil.opendataeditor.pages.dev

View logs

@guergana guergana requested review from roll, pdelboca and romicolman June 2, 2024 10:21
@romicolman
Copy link
Collaborator

@guergana I have just tested it and it's not working on Mac

@roll
Copy link
Collaborator

roll commented Jun 4, 2024

@guergana
Copy link
Collaborator Author

guergana commented Jun 4, 2024

@guergana
https://github.com/okfn/opendataeditor/blob/main/client/components/Parts/Bars/Menu.tsx#L21

Hi, thanks @roll could you provide some context? Why would this be better than capturing the native event?

@roll
Copy link
Collaborator

roll commented Jun 4, 2024

@guergana
Because the library probably covers the differences in native keyboard codes, although not sure about it

Generally speaking, I think it's better to use the lib that abstracts it (if it's already in-use in the project)

@guergana
Copy link
Collaborator Author

guergana commented Jun 6, 2024

@guergana Because the library probably covers the differences in native keyboard codes, although not sure about it

Generally speaking, I think it's better to use the lib that abstracts it (if it's already in-use in the project)

@roll According to the mozilla Javascript docs, it should work as it is now, using the event.key for both Mac and Windows.
We should test this together on your Mac @romicolman

This library is used across the whole app and not the native
events
@guergana guergana force-pushed the 350-add-backspace-key-to-file-delete branch from 38c018d to 379b3ba Compare June 7, 2024 14:33
@guergana guergana merged commit e5a87b8 into main Jun 7, 2024
8 checks passed
@guergana guergana deleted the 350-add-backspace-key-to-file-delete branch June 7, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot delete content of multiple cells
4 participants