Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide list of licenses #586

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Provide list of licenses #586

merged 4 commits into from
Oct 14, 2024

Conversation

roll
Copy link
Collaborator

@roll roll commented Oct 9, 2024


@romicolman
The problem here that currently the Data Package Standard only allows a license from a predefined list - https://datapackage.org/standard/data-package/#licenses (Open Definition Licenses).

I implemented the selector based on this limitation.

Here is an issue for Data Package - frictionlessdata/datapackage#855

@roll roll requested a review from guergana October 9, 2024 09:09
Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 61efd18
Status: ✅  Deploy successful!
Preview URL: https://3f69af70.opendataeditor.pages.dev
Branch Preview URL: https://351-improve-metadata-licensi.opendataeditor.pages.dev

View logs

@romicolman
Copy link
Collaborator

Hey @roll! Understood. I tested it and it works but I have a question. Is it possible to allow the user to type in this field and then the ODE will start showing the available options?

Captura de pantalla 2024-10-10 a la(s) 1 37 38 p  m

Something like this...

@roll
Copy link
Collaborator Author

roll commented Oct 10, 2024

Thanks, yea sure I will add it

Copy link
Collaborator

@guergana guergana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@roll
Copy link
Collaborator Author

roll commented Oct 11, 2024

@romicolman
Please take a look, it's updated

Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works OK! Thanks :)

@roll
Copy link
Collaborator Author

roll commented Oct 14, 2024

Thanks!

@roll roll merged commit 28c69a1 into main Oct 14, 2024
9 checks passed
@roll roll deleted the 351/improve-metadata-licensing branch October 14, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Licenses
3 participants