Proper loading states #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying opendataeditor with
|
| Latest commit: |
e3a7e6a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1a17da6f.opendataeditor.pages.dev |
| Branch Preview URL: | https://433-proper-loading-states.opendataeditor.pages.dev |
romicolman
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Hi @roll! The implementation of loading states is OK.
Regarding the description on the Rename option, can you revert changes and keep the original version? (order and list of options - seee image below):
Reason behind this: we did not add description for rename because in this case, the category was transparent for users.
|
@romicolman Reverted the change, please review (without a description and with this inconsistent order of actions the menu feels unfinished to me but might still be good enough as you say). |
|
Can we please merge this after: #654 ? these are three PRs with too many changes all based in main, i dont think it's a good idea. It's going to be very difficult with the merging |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@romicolman
Can you please try? It now properly handle states/errors for all the main operations (create/save/delete). It's better to test on large files.