Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metadata export #706

Merged
merged 8 commits into from
Dec 26, 2024
Merged

Support metadata export #706

merged 8 commits into from
Dec 26, 2024

Conversation

roll
Copy link
Collaborator

@roll roll commented Dec 24, 2024


Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

Copy link

cloudflare-workers-and-pages bot commented Dec 24, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 08a74eb
Status: ✅  Deploy successful!
Preview URL: https://48478e13.opendataeditor.pages.dev
Branch Preview URL: https://416-export-metadata.opendataeditor.pages.dev

View logs

@roll roll requested review from guergana and romicolman December 24, 2024 12:03
package.json Show resolved Hide resolved
Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roll! The functionality works ok. However, is it possible to implement these changes?

  • Change the icon of the export functionality. Can we use something more like a down array to indicate that something will be downloaded?
  • Is it possible to add the metadata button at the top right inside the metadata panel?
Captura de pantalla 2024-12-26 a la(s) 9 30 02 a  m
  • If this is not possible, please, let's make sure the Metadata button gets activated once people click on Metadata.
  • In the dialog, at the top of the dropdown box, let's add the word metadata next to Export:
Captura de pantalla 2024-12-26 a la(s) 9 34 25 a  m

@roll
Copy link
Collaborator Author

roll commented Dec 26, 2024

@romicolman
Hi, I updated the PR.

@roll roll merged commit f7cb8a8 into main Dec 26, 2024
9 checks passed
@roll roll deleted the 416/export-metadata branch December 26, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants