Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show lang in own lang #1004

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented Nov 9, 2023

It is a good practice to always show the language name in it's own language.

This PR simplifies the language_chooser to always display English Español

image

@pdelboca pdelboca requested a review from amercader November 9, 2023 09:39
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2098ff7) 88.35% compared to head (6815833) 88.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1004   +/-   ##
========================================
  Coverage    88.35%   88.35%           
========================================
  Files           94       94           
  Lines         1176     1176           
  Branches        48       48           
========================================
  Hits          1039     1039           
  Misses         135      135           
  Partials         2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdelboca pdelboca merged commit 538cb8a into develop Nov 9, 2023
2 checks passed
@pdelboca pdelboca deleted the 995-display-lang-selector-in-own-lang branch November 9, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants