Multiple issues with OpenAPI specification, leading to incorrect generated classes #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This generates an empty schema in the Java models
- PersonalAppsBlockList - RegistrationInlineHookResponse
- path parameters must be required - example should match pattern
clementdenis
requested a review
from arvindkrishnakumar-okta
as a code owner
|
@clementdenis Thanks for your PR! Will take a closer look. |
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
2 times, most recently
from
4cfa56d to
0f82ad6
Compare
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
2 times, most recently
from
92384bf to
224ebf6
Compare
OpenApi: Update InlineHooks to match the latest spec
antprnbackupta
force-pushed
the
fix-openapi-spec
branch
from
224ebf6 to
edd3b32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are multiple issues in the current API specification that prevent us from using the latest SDK version (since v19).
See the ticket in the OpenAPI spec repository for more details: okta/okta-management-openapi-spec#218
Category
Signoff