Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for included examples #61

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

raw1z
Copy link
Contributor

@raw1z raw1z commented Feb 27, 2024

add support for examples included with it_behaves_like

@olimorris
Copy link
Owner

Bonjour @raw1z 👋

Can you send an example Ruby file that you want to support? Unfortunately this just seems to break the tests that can be run with make test

@raw1z
Copy link
Contributor Author

raw1z commented Feb 28, 2024

Bonjour @raw1z 👋

Can you send an example Ruby file that you want to support? Unfortunately this just seems to break the tests that can be run with make test

I added example ruby files. I also made make test_core pass. I can't make make test_rspec pass. I noticed that it was also failing on the main branch so the errors might not come from the changes in this PR.

@olimorris
Copy link
Owner

Awesome. Thanks so much!

@olimorris olimorris merged commit 0d73fe6 into olimorris:main Feb 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants