[feat] Pass position_type to allow more rspec_cmd customization #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an RSpec test that uses data to generate tests such as:
The problem is that running a typical
bundle exec rspec
with the runner will show this passing even if some of the generated tests fail. I can fix it by making my commandbundle exec rspec --fail-fast
however now the entire test file will fail if a single test does.This PR enables someone to change the rspec command depending on the type of test they ran, which would fix my issue like so:
As a side note, I ran the test suite when I started but there were already failing specs. I made sure no new specs failed but I didn't fix those specs before implementing. Happy to change this PR with any changes you want.