Fix erroneous relative path resolution #726
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently FuseSoC has two problems related to relative path resolution,
The more severe one occurs when the fusesoc.conf file is in the current directory, in that case the code
files_read = self._cp.read(config_files)
returns only the file name, then in the function _resolve_path_from_cfg when
os.path.dirname
is called, an empty string is returned and when joined to form the final path we get a broken resultA second issue that I found is when referencing to a relative path starting with a dot, for example
./build_root
that dot stays in the path producing a result like/abs/path/to/./build_root
which although is a valid path, fails path comparisons, like the ones that are done forignored_dirs
This PR includes tests for both cases and fixes them.