fix: reading shared value during render

Fix #20
omahili · Jan 15, 2025 · ac43fad · ac43fad
1 parent 0f0f3e4
commit ac43fad
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/components/ReorderableListCore/useReorderableListCore.ts b/src/components/ReorderableListCore/useReorderableListCore.ts
@@ -1,4 +1,4 @@
-import React, {useCallback, useMemo} from 'react';
+import React, {useCallback, useEffect, useMemo} from 'react';
 import {
   FlatList,
   LayoutChangeEvent,
@@ -98,12 +98,12 @@ export const useReorderableListCore = <T>({
   const dragEndHandlers = useSharedValue<
     ((from: number, to: number) => void)[][]
   >([]);
-
-  // animation duration as a shared value allows to avoid re-rendering of all cells on value change
+  const startY = useSharedValue(0);
   const duration = useSharedValue(animationDuration);
-  if (duration.value !== animationDuration) {
+
+  useEffect(() => {
     duration.value = animationDuration;
-  }
+  }, [duration, animationDuration]);
 
   const listContextValue = useMemo(
     () => ({
@@ -115,8 +115,6 @@ export const useReorderableListCore = <T>({
     [draggedHeight, currentIndex, draggedIndex, dragEndHandlers],
   );
 
-  const startY = useSharedValue(0);
-
   const panGestureHandler = useMemo(
     () =>
       Gesture.Pan()