Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #110 in how to structure v05. In particular, instead of copy/pasting all of v04, this instead imports and modifies classes from v04 as needed. For this minimal example, this just imports and re-uses
ome_zarr_models.v04.labels.LabelsAttrs
, but I think for the more complex classes this will lead to saving quite a few duplicated lines of code.I've also added a
ome_attributes
property toBaseGroupv05
. My idea here was to add the same property toBaseGroupv04
, giving a consistent way to get at the OME specific attributes, regardless of whether they're under "ome" (v05) or not (v04).I think I like this more than #110, so will let this sit for a little while and merge it unless there's any feedback/suggestions otherwise.