Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Labels group object for v05 #118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dstansby
Copy link
Collaborator

This is an alternative to #110 in how to structure v05. In particular, instead of copy/pasting all of v04, this instead imports and modifies classes from v04 as needed. For this minimal example, this just imports and re-uses ome_zarr_models.v04.labels.LabelsAttrs, but I think for the more complex classes this will lead to saving quite a few duplicated lines of code.

I've also added a ome_attributes property to BaseGroupv05. My idea here was to add the same property to BaseGroupv04, giving a consistent way to get at the OME specific attributes, regardless of whether they're under "ome" (v05) or not (v04).

I think I like this more than #110, so will let this sit for a little while and merge it unless there's any feedback/suggestions otherwise.

@dstansby dstansby marked this pull request as ready for review January 11, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant