Implement bioformats2raw structure #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
force-pushed
the
bioformats2raw
branch
from
9798766 to
7794f4a
Compare
dstansby
force-pushed
the
bioformats2raw
branch
from
7794f4a to
b9fad79
Compare
On the pydantic side of the codebase, we can implement this with a function that tries validation of the different flavors of zarr group, from most specific to least specific, and returns the first class that matches? |
d-v-b
reviewed
Nov 25, 2024
d-v-b
reviewed
Nov 26, 2024
Co-authored-by: Davis Bennett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the parts of #31 that do not require parsing XML files (🙈) or zarr groups.
I think the intention of the spec is to have this as another "type" of dataset, alongside HCS and Image, even though it is defined in section 3 (not 2) of the spec. This agrees with the JSON scheme ipmlementaiton being in it's own file for bioformats2raw.
So I've put it in the
ome_zarr_models.v04namespace, and I think (for now) we are expecting users to know in advance whether they have a HCS, Image, or BioFormats2Raw dataset? I guess we could provide a convenience function to try work out which of these an arbitrary dataset is, but that should go in a separate PR