Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to SNAPSHOT for merge build #4

Merged
merged 5 commits into from
Sep 17, 2021
Merged

Bump to SNAPSHOT for merge build #4

merged 5 commits into from
Sep 17, 2021

Conversation

joshmoore
Copy link
Member

see: https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-build/jdk=JDK8,label=testintegration/872/console

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy (default-deploy) on project OMEZarrReader: Failed to deploy artifacts: Could not transfer artifact ome:OMEZarrReader:jar:0.0.1 from/to ome.staging (...nexus/repository/maven-internal/): Failed to transfer file: http://nexus:8081/nexus/repository/maven-internal/ome/OMEZarrReader/0.0.1/OMEZarrReader-0.0.1.jar. Return code is: 400, ReasonPhrase: Repository does not allow updating assets: maven-internal. -> [Help 1]

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely good to have the merge build reminding us to put the HEAD of the branch at a SNAPSHOT version.

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Sep 6, 2021

Conflicting PR. Removed from build BIOFORMATS-push#965. See the console output for more details.
Possible conflicts:

--conflicts Conflict resolved in build BIOFORMATS-push#966. See the console output for more details.

@joshmoore
Copy link
Member Author

@dgault @sbesson : thoughts welcome on the use of bio-formats-tools here. If we want to be more careful, I can put it in a profile and use -Ptools from ome_zarr_test_suite

@sbesson
Copy link
Member

sbesson commented Sep 14, 2021

Is the intended worfklow tocompile this repository with mvn and be able to immediately invoke the command-line utilities? Alternatively, I assume copying the JAR under the command-line tools bundle would work?

@joshmoore
Copy link
Member Author

This is the script that I'm currently trying to get working:

#!/usr/bin/env bash
set -e
set -u
test -e ZarrReader  || git clone git://github.com/ome/ZarrReader 1>&2
cd ZarrReader
mvn package -DskipTests # 1>&2
cd ..
java -cp ZarrReader/target/*.jar loci.formats.tools.ImageInfo -nopix "$@"

@dgault
Copy link
Member

dgault commented Sep 15, 2021

I don't really like the idea of including tools here, it isn't needed anywhere for the reader itself and would defeat the purpose of having this as a separate repo. Just copying the jar doesn't work with the tools either, there is a need slight modification needed.

@joshmoore
Copy link
Member Author

I'm not sure what you mean about the modification, but fair enough. I'll rollback the tools change and look into a script update that downloads tools from elsewhere.

@joshmoore
Copy link
Member Author

see: ome/ome_zarr_test_suite#16

@joshmoore
Copy link
Member Author

Ok. Considering this is a bump to SNAPSHOT, merging so I can continue my testing. Next step is either to get the unit tests in or to get this released to artifactory.

@joshmoore joshmoore merged commit 4316fb2 into ome:main Sep 17, 2021
@joshmoore joshmoore deleted the 0_1_0 branch September 17, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants